Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FWF-4343:[Feature]-Client form listing page. #2576

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from
Open

FWF-4343:[Feature]-Client form listing page. #2576

wants to merge 20 commits into from

Conversation

Josephalexantony-aot
Copy link
Member

@Josephalexantony-aot Josephalexantony-aot commented Feb 11, 2025 •
edited
Loading

Issue Tracking

JIRA: https://aottech.atlassian.net/browse/FWF-4343
Issue Type:FEATURE

Changes

New Client Form listing UI

Screenshots (if applicable)

image

image

the sort for submission count and description are yet to be added from the backend.

@Josephalexantony-aot Josephalexantony-aot requested review from a team as code owners February 11, 2025 13:53
@Josephalexantony-aot Josephalexantony-aot marked this pull request as draft February 11, 2025 13:58
@Josephalexantony-aot
Copy link
Member Author

@arun-s-aot The remaining sonar issue is neglected.

@arun-s-aot arun-s-aot marked this pull request as ready for review February 18, 2025 08:49
@arun-s-aot
Copy link
Contributor

@Josephalexantony-aot The duplication in the code can be neglected for now. But pls fix the [C Reliability Rating on New Code] in sonar issues.

@arun-s-aot
Copy link
Contributor

Please remove any unwanted code, methods and unwanted html tags to optimise the code @Josephalexantony-aot

@Josephalexantony-aot Josephalexantony-aot marked this pull request as draft February 18, 2025 13:22
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
28.0% Duplication on New Code (required ≤ 3%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Josephalexantony-aot Josephalexantony-aot marked this pull request as ready for review February 19, 2025 10:11
@arun-s-aot
Copy link
Contributor

Sonar issues with the testing files alone can be avoided

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arun-s-aot arun-s-aot arun-s-aot approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Josephalexantony-aot @arun-s-aot @Bonymol-aot